fix(keyboard): submit on enter keypress for checkboxes and radio buttons #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7679bcc:
|
777PolarFox777
force-pushed
the
pr/fix-submit-keyboard-event-for-checkboxes-and-radio-buttons
branch
from
eeb68ae
to
09e1149
Compare
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 51 +1
Lines 965 994 +29
Branches 389 413 +24
=========================================
+ Hits 965 994 +29
Continue to review full report at Codecov.
|
ph-fritsche
reviewed
Oct 15, 2021
|
🎉 This PR is included in version 13.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors add @777PolarFox777 code |
|
I've put up a pull request to add @777PolarFox777! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix submit event on Enter keypress for checkboxes and radio as requested in issue #730
Why:
To match browser's behavior
How:
Add one more keypress plugin that matches checkboxes and radios in the form with the submit button/input
Checklist: